WxxyDeveloper/JSL_OrganizeInternalOA
9
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix:完善业务发送消息 #37

Merged
XiaoLFeng merged 3 commits from feature-jie into develop 2024-04-20 19:55:57 +08:00
Conversation 0 Commits 3 Files Changed 3 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit abef74af38 - Show all commits

4
src/main/java/com/jsl/oa/services/impl/MessageServiceImpl.java
View File

@ -189,7 +189,7 @@ public class MessageServiceImpl implements MessageService {
String projectName = projectMapper.tgetProjectById(pId).getName(); String projectName = projectMapper.tgetProjectById(pId).getName();
String senderName = userDAO.getUserById(Processing.getAuthHeaderToUserId(request)).getUsername(); String senderName = userDAO.getUserById(Processing.getAuthHeaderToUserId(request)).getUsername();
String systemName = null; String systemName = null;
if (systemId != null) { if (systemId != null && projectMapper.getWorkById(systemId) != null) {
systemName = projectMapper.getWorkById(systemId).getName(); systemName = projectMapper.getWorkById(systemId).getName();
XiaoLFeng commented 2024-04-20 17:38:19 +08:00
Review
Copy Link

需要拆分开来写

projectMapper 获取部分若 systemId 为空，则 getName 会报空指针

需要拆分开来写 projectMapper 获取部分若 systemId 为空，则 getName 会报空指针
} }
// 添加消息 // 添加消息
@ -241,7 +241,7 @@ public class MessageServiceImpl implements MessageService {
String senderName = userDAO.getUserById(Processing.getAuthHeaderToUserId(request)).getUsername(); String senderName = userDAO.getUserById(Processing.getAuthHeaderToUserId(request)).getUsername();
String systemName = projectMapper.getWorkById(systmeId).getName(); String systemName = projectMapper.getWorkById(systmeId).getName();
String moddleName = null; String moddleName = null;
if (moddleId != null) { if (moddleId != null && projectMapper.getModuleById(moddleId) != null) {
moddleName = projectMapper.getModuleById(moddleId).getName(); moddleName = projectMapper.getModuleById(moddleId).getName();
} }
// 添加消息 // 添加消息